Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-1.23 K8s: Deprecate dockershim.sock and use containerd.sock for container runtime #2212

Closed
etungsten opened this issue Jun 13, 2022 · 1 comment
Closed

Non-1.23 K8s: Deprecate dockershim.sock and use containerd.sock for container runtime #2212

etungsten opened this issue Jun 13, 2022 · 1 comment
Assignees
@etungsten
Labels
status/needs-triage Pending triage or re-evaluation

Comments

@etungsten
Copy link
Contributor

etungsten commented Jun 13, 2022 •
edited
Loading

What I'd like:
More K8s deployments are now containerd-aware so customers are having to do K8s manifest edits for solutions that assume containerd as the underlying runtime.

In the containerd systemd service, we will create a symlink for the containerd socket at /run/dockershim.sock just so other deployments that assume docker as underlying runtime can still work.

We've already done this for 1.23 variants, this issue for tracking this change for other variants.

We tried implementing this change in #2173, but decided to delay the push-out until we can give sufficient notice to existing users.

Any alternatives you've considered:
@etungsten etungsten self-assigned this Jun 13, 2022
@etungsten etungsten mentioned this issue Jun 13, 2022
Closed
4 tasks
@joebowbeer joebowbeer mentioned this issue Jul 5, 2022
Merged
4 tasks
psact pushed a commit to psact/core-dump-handler that referenced this issue Jul 18, 2022
helm daemonset: Allow mounting the host container runtime socket
6f1237a 
Bottlerocket mounts the containerd socket under /run/dockershim.sock,
which does not appear to be part of the standard privileged container.
Add
  mountContainerRuntimeEndpoint: false
  hostContainerRuntimeEndpoint: "/run/containerd/containerd.sock"
 as chart defaults.

bottlerocket-os/bottlerocket@91810c8
bottlerocket-os/bottlerocket#2212
psact pushed a commit to psact/core-dump-handler that referenced this issue Jul 18, 2022
helm daemonset: Allow mounting the host container runtime socket
d65d074 
Bottlerocket mounts the containerd socket under /run/dockershim.sock,
which does not appear to be part of the standard privileged container.
Add
  mountContainerRuntimeEndpoint: false
  hostContainerRuntimeEndpoint: "/run/containerd/containerd.sock"
 as chart defaults.

bottlerocket-os/bottlerocket@91810c8
bottlerocket-os/bottlerocket#2212
@psact psact mentioned this issue Jul 19, 2022
Merged
psact pushed a commit to psact/core-dump-handler that referenced this issue Jul 20, 2022
@psact
helm daemonset: Allow mounting the host container runtime socket
6456a9e 
Bottlerocket mounts the containerd socket under /run/dockershim.sock,
which does not appear to be part of the standard privileged container.
Add
  mountContainerRuntimeEndpoint: false
  hostContainerRuntimeEndpoint: "/run/containerd/containerd.sock"
 as chart defaults.

bottlerocket-os/bottlerocket@91810c8
bottlerocket-os/bottlerocket#2212

Signed-off-by: Peter Scamardo <peter.scamardo@arthrex.com>
@stmcginnis stmcginnis added status/needs-triage Pending triage or re-evaluation and removed priority/p0 labels Dec 1, 2022
@stmcginnis
Copy link
Contributor

Resolved by #2173.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etungsten etungsten

Labels
status/needs-triage Pending triage or re-evaluation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stmcginnis @etungsten