-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies, tighten cargo-deny settings #919
Conversation
This is great! For the crate dependencies, I found we can reduce some duplication with the following changes:
|
The integration tests run kind, which creates a cluster within Docker. Since I changed these tests to be run within the SDK container, they failed without access to the docker socket. This change modifies the integration test runner to have access to the docker socket, plus network access to interact with the kind cluster running in an additional container. |
@jpculp Nice wrangling, though since these dependencies are smaller, I think may prefer to keep them more up-to-date over eliminating dupes. What do you think? |
I'm not super worried about As far as |
7227174
to
b843ecf
Compare
Good point! Force pushed for the dependency changes mentioned by @jpculp. |
b7e97e4
to
2aadbe7
Compare
Co-authored-by: Patrick J.P. Culp <jpculp@amazon.com>
This change also contains several major-version updates for dependencies to pass the cargo-deny checks.
I'm convinced that we can update our |
Description of changes:
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.