sonobuoy: re-set the assume role credentials if it expires #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1605299 to
bbb584b
Compare
We use IAM Role chaining on ephemeral testing infrastructure. Role chaining limits AWS CLI or AWS API role session to a maximum of one hour. When we assume the k8s new account role using role chaining and provide a DurationSeconds parameter value greater than one hour, the operation fails. Testsys sonobuoy agent needs more than one hour, so we need to refresh the credential frequently.
bbb584b to
2a84be3
Compare
|
Increase the frequency of credential refresh by reducing refresh loops from 110 to 50. |
webern
approved these changes
Mar 18, 2024
rpkelly
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We use IAM Role chaining on ephemeral testing infrastructure. Role chaining limits AWS CLI or AWS API role session to a maximum of one hour. When we assume the k8s new account role using role chaining and provide a DurationSeconds parameter value greater than one hour, the operation fails. Testsys sonobuoy agent needs more than one hour, so we need to refresh the credential when the client asks us to provide credentials
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.