ec2-resource-agent: deregister as ECS instance before termination #720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we terminate the EC2 instance, if the instance was previous registered as a ECS container instance, kick off ECS container instance deregisteration before terminating the EC2 instance.
Issue number:
Resolves #717
Description of changes:
Testing done:
EC2 resource agent for ECS clusters delete cleanly and ensures all ECS container instances are de-registered with a 5 min timeout that doesn't error and proceeds to terminate the EC2 instance.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.