Remove the dependency on six. #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces #2512 Leaves vendored six.py and tests/functional/test_six_threading.py intact. Otherwise references of six were removed from everywhere and the code depends on the standard library instead.
nateprewitt
requested changes
Nov 2, 2022
There was a problem hiding this comment.
Thanks for the pared down PR, @mcepl! A couple minor comments, I believe the one around bytes should solve the test failures. Please let us know if you have any questions.
Co-authored-by: Nate Prewitt <nate.prewitt@gmail.com>
Co-authored-by: Nate Prewitt <nate.prewitt@gmail.com>
Co-authored-by: Nate Prewitt <nate.prewitt@gmail.com>
Codecov ReportBase: 93.45% // Head: 93.44% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2806 +/- ##
===========================================
- Coverage 93.45% 93.44% -0.01%
===========================================
Files 63 63
Lines 13298 13297 -1
===========================================
- Hits 12427 12426 -1
Misses 871 871
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nateprewitt
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2512
Leaves vendored six.py and tests/functional/test_six_threading.py intact.
Otherwise references of six were removed from everywhere and the code depends on the standard library instead.