update API doc based on https://github.com/bosnet/sebak/pull/863/ #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfangw
approved these changes
Jan 7, 2019
There was a problem hiding this comment.
LGTM.
But, please commit after the change is released.
bosnet/sebak#863
|
@kfangw got it. Thanks for reviewing. |
|
@cmcm2222 Please deploy the DOC when the v0.1.5 released. |
soonkuk
requested changes
Jan 31, 2019
| @@ -33,6 +33,13 @@ | |||
| + fee: 10000 | |||
| + hash: `7nLuyg8radTExzBM2WhG37AwohBwEySBw4vj2xdtdjAs` | |||
| + operation_count: 1 | |||
| + operations: | |||
There was a problem hiding this comment.
In transaction, block: 241 should be changed
when I call the api in testnet block shows block hash
soonkuk
requested changes
Jan 31, 2019
| + type : `payment` - operation type. ex. payment, create-account | ||
| + B | ||
| + target : `GCIKBR6QXYF6VLLTXC7EHKDGAPAOLSRALZTWTLZ2SANBYWMWT6AURQGG` | ||
| + amount : `100000` - amount in GON |
There was a problem hiding this comment.
txs, block-height, block-hash , total-txs, total-ops should be included
There was a problem hiding this comment.
when you see the `payment' type.
https://mainnet.blockchainos.org/api/v1/transactions/EqGR1c3S3dMDD6ZDxusAxuLNJGErb1tzS56Q2QNYUUoW
you can see that it is different with inflation or collect-tx-fee.
soonkuk
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR#863, API doc is updated.
please review it.