Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various warnings #975

Merged
merged 4 commits into from
Dec 21, 2021
Merged

Fix various warnings #975

merged 4 commits into from
Dec 21, 2021

Conversation

varunagrawal
Copy link
Collaborator

This PR fixes a bunch of compilation warnings.

  1. Alignment warnings for TriangulationFactor.
  2. Deprecation warnings for axpy in Errors.h.
  3. OSX Clang visibility warnings due to instantiations in Potentials.cpp.
  4. I also added a bunch of GTSAM_EXPORTs in various classes of discrete/ for cross-platform compatibility.

@varunagrawal varunagrawal self-assigned this Dec 21, 2021
dellaert
dellaert approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks !!!

@dellaert dellaert merged commit 598c81f into develop Dec 21, 2021
@dellaert dellaert deleted the fix/warnings branch December 21, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

@gchenfc gchenfc Awaiting requested review from gchenfc

Assignees

@varunagrawal varunagrawal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert