Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of savings! #2016

Merged
merged 6 commits into from
Jan 31, 2025
Merged

Lots of savings! #2016

merged 6 commits into from
Jan 31, 2025

Conversation

dellaert
Copy link
Member

  • dynamic -> static casts is really a big boon
  • some other small savings
    image

@dellaert dellaert requested a review from varunagrawal January 31, 2025 18:18
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some super minor things.

examples/Hybrid_City10000.cpp Outdated Show resolved Hide resolved
gtsam/hybrid/HybridBayesNet.cpp Show resolved Hide resolved
gtsam/linear/HessianFactor.cpp Show resolved Hide resolved
@dellaert dellaert merged commit c37eb49 into develop Jan 31, 2025
35 checks passed
@dellaert dellaert deleted the feature/hybrid_profiling branch February 1, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants