-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 4.0.2 #130
Conversation
We sometimes make little mistakes like this on purpose, just to keep people on their toes :-) Will merge and kill Travis builds |
Naughty developers... 😆 Don't forget to update the tag then too. 😉 Cheers! |
Hmmm, updating a tag seems to be discouraged. Maybe a new tag 4.0.2a? |
Although that sounds like alpha. |
It is very discouraged... :/ Forcing the tag update would keep the repo in the "right state" (tag naming matching code version), but may mess with some clones/forks of the repo. Changing the tag name would make it look like a newer version, when in fact it's not. Not sure what to do here... I think it will be up to you guys to chose one. |
Personally I would update the tag and warn the community about the mistake. I believe most of people using GTSAM would be able to handle this update. |
@varunagrawal could you move the tag and post to google group? |
GTSAM uses Gitflow, see https://nvie.com/posts/a-successful-git-branching-model/ |
Oh, OK, so I messed up when I proposed the merge on top of master... 😅 Sorry about that. I'll take more care next time. |
Yup I'll do it. |
Hi,
I noticed the version was not bumped after 4.0.2 release, so I bumped it on this PR.
It was also not bumped for 4.0.1... was this on purpose ?
Cheers!
This change is