Skip to content

Commit

Permalink
Added more GTSAM_DEPRECATED directives
Browse files Browse the repository at this point in the history
  • Loading branch information
dellaert committed Jan 3, 2022
1 parent 754d036 commit cf50d10
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion gtsam/geometry/Cal3.h
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ class GTSAM_EXPORT Cal3 {

#ifdef GTSAM_ALLOW_DEPRECATED_SINCE_V42
/** @deprecated The following function has been deprecated, use K above */
Matrix3 matrix() const { return K(); }
Matrix3 GTSAM_DEPRECATED matrix() const { return K(); }
#endif

/// Return inverted calibration matrix inv(K)
Expand Down
4 changes: 2 additions & 2 deletions gtsam/geometry/Cal3Bundler.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ class GTSAM_EXPORT Cal3Bundler : public Cal3 {

#ifdef GTSAM_ALLOW_DEPRECATED_SINCE_V42
/// get parameter u0
inline double u0() const { return u0_; }
inline double GTSAM_DEPRECATED u0() const { return u0_; }

/// get parameter v0
inline double v0() const { return v0_; }
inline double GTSAM_DEPRECATED v0() const { return v0_; }
#endif

/**
Expand Down
2 changes: 1 addition & 1 deletion gtsam/geometry/SimpleCamera.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
namespace gtsam {

#ifdef GTSAM_ALLOW_DEPRECATED_SINCE_V42
SimpleCamera simpleCamera(const Matrix34& P) {
SimpleCamera GTSAM_DEPRECATED simpleCamera(const Matrix34& P) {

// P = [A|a] = s K cRw [I|-T], with s the unknown scale
Matrix3 A = P.topLeftCorner(3, 3);
Expand Down
3 changes: 2 additions & 1 deletion gtsam/linear/GaussianConditional.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@ namespace gtsam {

/* ************************************************************************* */
#ifdef GTSAM_ALLOW_DEPRECATED_SINCE_V42
void GaussianConditional::scaleFrontalsBySigma(VectorValues& gy) const {
void GTSAM_DEPRECATED
GaussianConditional::scaleFrontalsBySigma(VectorValues& gy) const {
DenseIndex vectorPosition = 0;
for (const_iterator frontal = beginFrontals(); frontal != endFrontals(); ++frontal) {
gy[*frontal].array() *= model_->sigmas().segment(vectorPosition, getDim(frontal)).array();
Expand Down

0 comments on commit cf50d10

Please sign in to comment.