-
-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not use broken setuptools version #6223
do not use broken setuptools version #6223
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6223 +/- ##
==========================================
+ Coverage 83.03% 83.23% +0.20%
==========================================
Files 38 38
Lines 10385 10385
Branches 2038 2038
==========================================
+ Hits 8623 8644 +21
+ Misses 1249 1233 -16
+ Partials 513 508 -5
Continue to review full report at Codecov.
|
628ccbf
to
a6dbee0
Compare
a6dbee0
to
456bf4c
Compare
Is this still required? pycalphad/pycalphad#393 (comment)
|
If so, wouldn't a better fix be |
https://github.com/pypa/setuptools/releases I see:
|
Our change is not required any more for fresh virtual envs considering the new version is released now. Using >= would be wrong as we also work with many other versions, except the broken one. We can remove this later again, but guess we better keep it for a while. |
The backport is merged. The backport/1.1-maint label can be removed. |
see there: pypa/setuptools#3063