Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use broken setuptools version #6223

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

ThomasWaldmann
Copy link
Member

@ThomasWaldmann ThomasWaldmann commented Feb 2, 2022

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #6223 (456bf4c) into master (2b81943) will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6223      +/-   ##
==========================================
+ Coverage   83.03%   83.23%   +0.20%     
==========================================
  Files          38       38              
  Lines       10385    10385              
  Branches     2038     2038              
==========================================
+ Hits         8623     8644      +21     
+ Misses       1249     1233      -16     
+ Partials      513      508       -5     
Impacted Files Coverage Δ
src/borg/archive.py 82.06% <0.00%> (+0.51%) ⬆️
src/borg/xattr.py 51.19% <0.00%> (+1.19%) ⬆️
src/borg/helpers/fs.py 83.63% <0.00%> (+1.21%) ⬆️
src/borg/helpers/misc.py 78.77% <0.00%> (+1.67%) ⬆️
src/borg/platform/base.py 81.19% <0.00%> (+3.41%) ⬆️
src/borg/platform/__init__.py 84.00% <0.00%> (+12.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b81943...456bf4c. Read the comment docs.

@ThomasWaldmann ThomasWaldmann changed the title fix github codeql pip cache caching do not use broken setuptools version Feb 2, 2022
@ThomasWaldmann ThomasWaldmann merged commit f96e443 into borgbackup:master Feb 2, 2022
@ThomasWaldmann ThomasWaldmann deleted the fix-codeql-master branch February 2, 2022 04:45
@hexagonrecursion
Copy link
Contributor

Is this still required?

pycalphad/pycalphad#393 (comment)

pypa/setuptools#3070 is fixes pypa/setuptools#3063 in setuptools 60.6.0 and 60.7.0 is available now.

@hexagonrecursion
Copy link
Contributor

hexagonrecursion commented Feb 3, 2022

If so, wouldn't a better fix be setuptools >=60.7.0 ?

@hexagonrecursion
Copy link
Contributor

https://github.com/pypa/setuptools/releases

I see:

  1. v60.5.0 released Jan 8
  2. The bug was introduced Jan 14 pypa/setuptools@dba50bf
  3. The only broken version (v60.6.0) was released Jan 31
  4. The fix (v60.7.0) was released Feb 2 10:32 UTC

@ThomasWaldmann
Copy link
Member Author

Our change is not required any more for fresh virtual envs considering the new version is released now.
For existing virtual envs that have the broken version, we better force upgrading it by requirement.

Using >= would be wrong as we also work with many other versions, except the broken one.

We can remove this later again, but guess we better keep it for a while.

@hexagonrecursion
Copy link
Contributor

The backport is merged. The backport/1.1-maint label can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants