Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update referenced freebsd version #5945

Merged
merged 3 commits into from Aug 5, 2021
Merged

docs: update referenced freebsd version #5945

merged 3 commits into from Aug 5, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 31, 2021

Fixes: #5942

@ThomasWaldmann
Copy link
Member

no, we can't do it like that:

  • changes.rst should be readable in source form also, so there is no placeholder expansion
  • entries in changes.rst (esp. older ones) are not supposed to change (when updating the placeholder definition)

@ghost
Copy link
Author

ghost commented Jul 31, 2021

Hmm OK, I'll redo it.

@ghost ghost closed this Jul 31, 2021
@ghost ghost reopened this Aug 3, 2021
@ghost
Copy link
Author

ghost commented Aug 3, 2021

OK if I understood correctly, all I needed to do was revert the changes to the changelog. Couldn't find any other instances that needed to be updated.

@ThomasWaldmann ThomasWaldmann merged commit 79db0b0 into borgbackup:master Aug 5, 2021
@ThomasWaldmann
Copy link
Member

Thanks!

@ThomasWaldmann
Copy link
Member

Can you check same for 1.1-maint (binary build OS versions see Vagrantfile there)?

ThomasWaldmann pushed a commit that referenced this pull request Aug 6, 2021
docs: fix binary build freebsd/macOS version, fixes #5942

backports of #5945
@ghost ghost mentioned this pull request Aug 7, 2021
@ghost ghost mentioned this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some docs still reference freebsd 10.3 although we use 12.1
2 participants