pyinstaller ssh/openssh library loading issue / OpenSSL version mismatch

[ThomasWaldmann]

From the mailing list, reported by cherio:

Remote: OpenSSL version mismatch. Built against 1010106f, you have 101000cf

It seems issue #514 is there again.
This was observed using borg-linux64 and borg-linux64.tgz 1.1.15 and 1.1.16, but not with 1.1.14.

1.1.14 was last borg built with pyinstaller 3.2.1.
1.1.15 was built with 4.0, 1.1.16 was built with 4.2.

The user uses borg binaries on Ubuntu 20.04.

> openssl version
OpenSSL 1.1.1f  31 Mar 2020

> ssh -V
OpenSSH_8.2p1 Ubuntu-4ubuntu0.2, OpenSSL 1.1.1f  31 Mar 2020

> python
Python 3.8.5 (default, May 27 2021, 13:30:53)
[GCC 9.3.0] on linux
>>> import ssl
>>> ssl.OPENSSL_VERSION
'OpenSSL 1.1.1f  31 Mar 2020'

So, system openssl is 1.1.1f, system ssh wants 1.1.1f.
Very likely the pyi bundle has 1.1.0 (for bundled python).

Related borg code:

• https://github.com/borgbackup/borg/blob/1.1.16/src/borg/helpers.py#L2407
• https://github.com/borgbackup/borg/blob/1.1.16/src/borg/remote.py#L553

[ThomasWaldmann]

I think the bug is slightly different than described above (update: cherio confirmed it is only in single-dir mode):

The problem is that LD_LIBRARY_PATH_ORIG is only provided by pyinstaller, if there was a LD_LIBRARY_PATH in the original env. If not, things get complicated:

https://github.com/borgbackup/borg/blob/1.1.16/src/borg/helpers.py#L2426

We check there if the LDLP contains _MEI, but that is only the case for the single-file pyi bundle.
For the single-dir bundle, it is just the absolute path of the unpacked bundle (not _MEI temp path).

Workaround for using the single-dir bundle, avoiding the problematic part of the code:

LD_LIBRARY_PATH=/invalid borg ... ssh://user@host/repo ...

[ThomasWaldmann]

see also there: pyinstaller/pyinstaller#2892