log output 1.0.x client -> 1.1.0 server

[ThomasWaldmann]

$ borg-1.0.6 create -v tw@localhost:repo::test input
borg.output.progress Remote: Compacting segments   0%
borg.output.progress Remote: Compacting segments  50%
borg.output.progress Remote:

Same for 1.0.11 client.

The unusual borg.output.progress at the left is the logname included by the server and unexpected to show up there for a 1.0 client.

[ThomasWaldmann]

1.0 client supports these server log line formats:

$LOG <level> Remote: <msg>  # output via logging at level: "Remote: <msg>", line ending stripped
msg                         # output via stderr with "Remote: " prepended, line ending preserved

1.1 client supports these:

json
$LOG <level> <logname> Remote: <msg>  # output via logger <logname> at <level>, le stripped
$LOG <level> Remote: <msg>  # output via logging at level: "Remote: <msg>", line ending stripped
msg                         # output via stderr with "Remote: " prepended, line ending preserved

[ThomasWaldmann]

https://github.com/borgbackup/borg/blob/1.1.0/src/borg/logger.py#L92 there it includes the logname.

Hmm, as the server will talk json to any recent 1.1 client, just use the simpler format without logname for the non-json case? @enkore

[enkore]

Should work. That's effectively another beta/RC format.

[ThomasWaldmann]

another issue: this is progress log output, so it should not be output at all (except with --progress).

problem: borg does not pass --progress to server, so the server can't suppress it based on that. so, the client would have to suppress it (which works fine in 1.1, but not 1.0).

the only way the client could suppress it (except running on WARNING level) is if the client knows the logger name.

so, rather support the $LOG format with logger name for future borg? wouldn't help for past 1.0 clients though.

[ThomasWaldmann]

removing from milestone, this problem solves automatically as people upgrade to 1.1.x.