Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage build fails under 10.11 #57

Closed
vasarhelyia opened this issue Oct 25, 2015 · 5 comments
Closed

Carthage build fails under 10.11 #57

vasarhelyia opened this issue Oct 25, 2015 · 5 comments

Comments

@vasarhelyia
Copy link
Contributor

I received this issue the other day on my project and it seems this problem occurs under OS X 10.11 & Xcode 7.1 with the framework.

Building the project with Carthage gives an error like it's unable to find destination and the destination was a Core Simulator iPhone 4S, iOS 9.1. I've checked the build settings of the ISO8601 framework target and the only thing unfamiliar to me is that the architectures were not set to Standard (armv7, arm64). I gave it a try setting it standard and it solved this issue.

I've created an issue, not a PR because I'm not aware of why do you have different settings for architecture, I would appreciate your help clarifying it. Honestly, I have no idea why does setting it to standard solve this problem if it worked perfectly under 10.10 and Xcode 7.0, couldn't find any useful information about it. It might even be a Carthage issue, I will ask them for help as well.

@boredzo
Copy link
Owner

boredzo commented Oct 26, 2015

I think this might be left over from ISO 8601 Date Formatter's days as a Mac-only, iOS-not-terribly-prioritized thing. Setting the architectures to ARCHS_STANDARD_64_BIT specifically excludes 32-bit—in the context of the Mac, meaning i386, which has the Legacy Runtime.

(Note that at the time I set that, ARCHS_STANDARD included both i386 and x86_64.)

On Apple's other platforms, that doesn't make sense. ARM 32-bit and 64-bit both use the Modern Runtime.

I'm going to push a branch with ARCHS set to standard in the project and overridden at the same level for Mac SDKs. Stand by.

@boredzo
Copy link
Owner

boredzo commented Oct 26, 2015

Please try that branch and let me know whether it fixes the issue.

@boredzo
Copy link
Owner

boredzo commented Oct 26, 2015

@vasarhelyia
Copy link
Contributor Author

It builds with Carthage perfectly on the branch. Thanks a lot for the clarification and the modification!

@boredzo
Copy link
Owner

boredzo commented Oct 26, 2015

Thanks for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants