[BOOST-4692] Support chainId in EventAction #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
718ea2a to
f4d1e30
Compare
|
@Quazia should we configure a new default branch for this repo now that we're mid-audit? |
f4d1e30 to
fec1df0
Compare
273ead6 to
832c1b2
Compare
|
can you also add a changeset? https://github.com/rabbitholegg/boost-protocol?tab=readme-ov-file#changesets--publishing |
832c1b2 to
68adb88
Compare
|
While most of this validation occurs offchain, it is important to uniquely identify the smart contract we're watching
68adb88 to
c06e40d
Compare
|
@sammccord I'm waiting for the audit to "finish" to start pushing changes |
The chainid typing is a bit dicey. it's a uint256 but treated as a number by viem, so I have upgrade and downgrade conversion functions implemented to help with this
c06e40d to
cd3c2ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves BOOST-4706: Add chainId to event action parameters
resolves BOOST-4707: support chainid in EventAction
chainId is needed to disambiguate the location of the address