[BOOST-4693] Event Action Beautification / Hardening #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quazia
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
This looks good - if we have time I'd like to add tests for some of the other validation properties just to make sure but that's definitely out of scope for this. Looks like the address validation had an issue? It's good we have the EventAction tests in the SDK now.
packages/sdk/src/Actions/Action.ts
Outdated
| */ | ||
| export const ActionByComponentInterface = { | ||
| // ['0x6c3129aa']: ContractAction, | ||
| // ['0x97e083eb']: ERC721MintAction, | ||
| ['0x7687b0ed']: EventAction, | ||
| ['0x6c3129aa']: EventAction, |
There was a problem hiding this comment.
The contract didn't change so is the interface we published with wrong?
| test('can get the total number of action steps', async () => { | ||
| const action = await loadFixture(cloneEventAction(fixtures, erc721)); | ||
| const count = await action.getActionStepsCount(); | ||
| expect(count).toBe(1); |
0f68693 to
0df8080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EventActionPayloadSimplewhere you can passactionSteps: ActionStep[]instead of{ actionStepOne: ActionStep, ...etc }getActionStep,getActionSteps, etc. dedupe reused action steps, so while there are technically always 4 on the contract, the sdk will know which ones are unique.