Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOOST-4638] Interface and Abstract Cleanup #68

Merged
merged 2 commits into from
Sep 9, 2024
Merged

[BOOST-4638] Interface and Abstract Cleanup #68

merged 2 commits into from
Sep 9, 2024

Conversation

topocount
Copy link
Contributor

@topocount topocount commented Sep 6, 2024 •
edited
Loading

  • chore(evm): prepend abstracts with A
  • chore(evm): migrate unshared business logic to impl contracts

also closes BOOST-4605

@topocount topocount requested a review from Quazia September 6, 2024 15:07
@topocount topocount requested a review from a team as a code owner September 6, 2024 15:07
@topocount topocount requested a review from sammccord September 9, 2024 17:47
@topocount
chore(evm): prepend abstracts with A
a295114
@topocount
chore(evm): migrate unshared business logic to impl contracts
537dc22 
Any unshared logic is moved to impls, while preserving public interfaces
to ensure interfaces are available to the sdk

This includes migrating ACL logic to impl contracts out of abstracts
because they have no EIP-165 interfaces
@topocount topocount merged commit 9a4d71b into main Sep 9, 2024
3 checks passed
@topocount topocount deleted the interface-impl branch September 9, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quazia Quazia Awaiting requested review from Quazia

@sammccord sammccord Awaiting requested review from sammccord

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@topocount