Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOOST-5223] feat(evm): implement managed budget V2 #373

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

topocount
Copy link
Contributor

@topocount topocount commented Jan 17, 2025

This iteration of managed budget tracks BoostCore deployments that the
budget targets over time, and allows managers to interact with
deprecated versions via overloaded functions. Since much of the security
model for boosts is contained in BoostCore, managers cannot access a
boost core deployment that was not already set by an admin.

management fee payouts on BoostCore against boosts not
deployed by a budget fail thanks to pre-existing logic that tracks
disbursements and stores the incentive address. If the incentive address
in the boost does not match that of the disbursement, it will fail, and replays against multiple BoostCore deployments will fail

This iteration of managed budget tracks BoostCore deployments that the
budget targets over time, and allows managers to interact with
deprecated versions via overloaded functions. Since much of the security
model for boosts is contained in BoostCore, managers cannot access a
boost core deployment that was not already set by an admin.

management fee payouts on BoostCore against boosts not
deployed by a budget fail thanks to pre-existing logic that tracks
disbursements and stores the incentive address. If the incentive address
in the boost does not match that of the disbursement, it will fail.
@topocount topocount requested a review from Quazia January 17, 2025 16:58
Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: f8baefe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the EVM label Jan 17, 2025
@sammccord
Copy link
Contributor

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against f8baefe

@sammccord
Copy link
Contributor

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against f8baefe

@Quazia Quazia merged commit 6b73d4f into main Jan 24, 2025
7 checks passed
@Quazia Quazia deleted the managed-budget-v2 branch January 24, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants