Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOOST-5221] feat(sdk): update tuple support helpers to add terminators #371

Merged

Conversation

Quazia
Copy link
Member

@Quazia Quazia commented Jan 15, 2025

🚨 Please review the guidelines for contributing to this repository.

Description

The usage of terminators was confusing for integrators so now we automatically add a terminator so users of the SDK don't need to understand how the field index packing works as well. Now when an array of less than five is packed into the packing function we just automatically append a terminator so that the underlying data structure doesn't need to be understood at all at the application level.
💔 Thank you!

Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: 73b3897

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@boostxyz/sdk Patch
@boostxyz/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the SDK label Jan 15, 2025
@Quazia Quazia requested a review from mmackz January 15, 2025 16:23
@sammccord
Copy link
Contributor

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 2b8c50c

@mmackz
Copy link
Contributor

mmackz commented Jan 15, 2025

Nice!

Copy link
Contributor

@mmackz mmackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to add a changeset and we can get this in next release.

@Quazia Quazia enabled auto-merge (rebase) January 15, 2025 19:22
@Quazia Quazia merged commit cf262d1 into main Jan 15, 2025
6 checks passed
@Quazia Quazia deleted the arthur/boost-5221-update-tuple-support-helpers-to-add-terminators branch January 15, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants