Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOOST-5215] feat(evm): uint vs int handling in event action #368

Open
wants to merge 2 commits into
base: arthur/boost-5216-add-incentives-to-boosts
Choose a base branch
from

Conversation

Quazia
Copy link
Member

@Quazia Quazia commented Jan 15, 2025

🚨 Please review the guidelines for contributing to this repository.

Description

Fairly straightforward. Adds the primitive type into the EventAction and then makes the corresponding changes in the SDK. We're also going to need to make changes in the application to handle int values on ABIs. Another thing to consider is that int/uint values less than 256 should also probably be supported. This only gets gnarly when it's a uint value smaller than bigInt which I believe is around uint64?
💔 Thank you!

Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: 71ec717

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sammccord
Copy link
Contributor

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 71ec717

@topocount topocount changed the base branch from main to arthur/boost-5216-add-incentives-to-boosts January 15, 2025 15:16
@sammccord
Copy link
Contributor

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 71ec717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants