Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOOST-5197] update transfer signature logic to allow for deriving claimant #364

Merged

Conversation

mmackz
Copy link
Contributor

@mmackz mmackz commented Jan 14, 2025

Description

  • removes event action validation from decodeTransferLogs method
  • applies decodeTransferLogs in the deriveActionClaimantFromTransaction method
  • fixes lint warning in decodeAndReorderLogArgs Do not use new Array(singleArgument)
  • tested locally

Copy link

changeset-bot bot commented Jan 14, 2025

🦋 Changeset detected

Latest commit: 393de1b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@boostxyz/sdk Patch
@boostxyz/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the SDK label Jan 14, 2025
@sammccord
Copy link
Contributor

Warnings
⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 7b94f3d

} catch {
// ERC20
try {
event.inputs[2]!.indexed = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mmackz mmackz merged commit 34308e9 into main Jan 15, 2025
6 checks passed
@mmackz mmackz deleted the matthew/boost-5197-transfer-signature-error-in-signatures-endpoint branch January 15, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants