Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BOOST-4438] ManagedBudget Contract #32

Merged
merged 2 commits into from
Aug 30, 2024
Merged

[BOOST-4438] ManagedBudget Contract #32

merged 2 commits into from
Aug 30, 2024

Conversation

sammccord
Copy link
Contributor

@sammccord sammccord commented Aug 23, 2024 •
edited
Loading

  • Implement ManagedBudget contract based on SimpleBudget
    • reclaim is only available to ADMIN | owner
    • disburse is available to ADMIN | MANAGER | owner
    • setAuthorized is available to ADMIN | owner
    • grantRoles is available to ADMIN | owner
    • revokeRoles is available to ADMIN | owner
  • Implement ManagedBudget.t.sol unit tests for core SimpleBudget operations

fix BOOST-4439

@sammccord sammccord force-pushed the sam/boost-4438-managed-budget-contract branch from 2655e17 to 4ef88e8 Compare August 26, 2024 17:36
@sammccord sammccord marked this pull request as ready for review August 26, 2024 17:37
@sammccord sammccord requested a review from a team as a code owner August 26, 2024 17:37
@sammccord sammccord force-pushed the sam/boost-4438-managed-budget-contract branch from 4ef88e8 to a1a7eb8 Compare August 26, 2024 17:39
@sammccord sammccord requested a review from Quazia August 27, 2024 15:30
@sammccord sammccord force-pushed the sam/boost-4438-managed-budget-contract branch from d8694e7 to 9c484e2 Compare August 30, 2024 16:42
@sammccord sammccord enabled auto-merge August 30, 2024 16:42
@sammccord sammccord disabled auto-merge August 30, 2024 16:52
@sammccord sammccord merged commit 94d43b4 into main Aug 30, 2024
3 checks passed
@sammccord sammccord deleted the sam/boost-4438-managed-budget-contract branch August 30, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quazia Quazia Awaiting requested review from Quazia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sammccord