-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT & Server] Week2 마무리 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project setting server
- app.controller.ts -> socket.controller.ts - app.controller.ts -> socket.controller.ts - app.controller.ts -> socket.module.ts - app.controller.spec.ts -> socket.controller.spec.ts - app.e2e-spec.ts
- userInfo에 있는 스키마(pw, refreshToken)를 user 스키마에 통합
- SignInDto : 로그인 인풋 포맷 - SignUpDto : 회원가입 인풋 포맷
- email -> id
- usersRepository -> userRepository
- ./user/auth -> ./auth - auth 구현중인 내용 있음
- ./user/auth/dto -> ./auth/dto
- @api/* : ["apps/api/*"]
- CreateUserDto -> SignUpDto
- 비밀번호 hash로 변환 - DB 저장 - 중복시 예외처리
- message(string) -> data(any) - any로 둔 이유 : 반환하는 것이 너무 다양해서 타입을 지정하기가 어려움
- 매개변수로 들어오는 condition에 해당하는 것을 하나만 찾아서 반환해주는 함수
- DB에 아이디가 없으면 예외처리 - 비밀번호가 일치하지 않으면 예외처리
- service에서 응답을 생성했던 것을 controller 에서 응답 생성하도록 수정
- 변경 전 : service에서 error 발생 시 반환하고, controller에서 반환값이 error이면 에러 처리 - 변경 후 : service에서 error 발생 시 바로 throw 하기 (error 발생 시 바로 처리)
- 팔로잉 목록을 보여주는 기능 뿐만 아니라 검색 기능을 담당하고 있음
string -> null | string
[Server] 회원가입, 로그인, 팔로잉
soomanbaek
reviewed
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨어요!
soomanbaek
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨어요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤷♂️ Description