Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server] Feature/find user #57

Merged
merged 4 commits into from
Nov 16, 2022
Merged

[Server] Feature/find user #57

merged 4 commits into from
Nov 16, 2022

Conversation

NaayoungKwon
Copy link
Collaborator

Issues

🤷‍♂️ Description

  • 특정 사용자 정보 요청시 data 전달

📷 Screenshots

  • 정상

image

  • 없는 사용자

image

  • object id 형식이 아닐 때

image

@NaayoungKwon NaayoungKwon added the 🌐 server 서버 작업 label Nov 16, 2022
@NaayoungKwon NaayoungKwon added this to the ⛰️ Week2 milestone Nov 16, 2022
Copy link
Member

@soomanbaek soomanbaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요~ 👍👍

Comment on lines 63 to 68
return {
id: user.id,
nickname: user.nickname,
status: user.status,
profileUrl: user.profileUrl,
description: user.description,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 자주 사용할 수도 있어서 저런 형식의 객체를 반환하는 함수로 만들어도 괜찮을 거 같아요!
ex) getUserForm(user);

@soomanbaek soomanbaek merged commit 73ddb91 into dev-be Nov 16, 2022
@NaayoungKwon NaayoungKwon deleted the feature/findUser branch November 17, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 server 서버 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants