Week 4 Backend Branch Merge to Dev #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b01792c)
(cherry picked from commit aff6f52)
(cherry picked from commit ec0b4be)
- 비동기시, 서비스 안에서 에러 throw 한 것을 controller에서 catch하지 못함 (cherry picked from commit 18b4040)
(cherry picked from commit c1a8bb0)
(cherry picked from commit 73bf217)
(cherry picked from commit 18f355e)
(cherry picked from commit bf7bdcd)
(cherry picked from commit 80acfe4)
(cherry picked from commit 64f25e6)
- es6 최신 문법으로 수정 (cherry picked from commit 7152d97)
(cherry picked from commit 015c19d)
(cherry picked from commit 44a3fc4)
(cherry picked from commit 88a1295)
(cherry picked from commit fcf9841)
(cherry picked from commit bec345c)
- private 채널 : 관리자만 채널에 추가 - public 채널 : 커뮤니티 유저 모두 채널에 추가 (cherry picked from commit 7e87ba1)
(cherry picked from commit 6019922)
(cherry picked from commit a9305df)
(cherry picked from commit 0acd9cf)
(cherry picked from commit 95b00d1)
(cherry picked from commit ea9e026)
(cherry picked from commit fcb1e19)
- 관리자가 아닐 시 에러처리 - channel에 속한 모든 user들에 대하여 user 도큐먼트에 communities:channels 필드 수정 - channel 도큐먼트 softDelete (cherry picked from commit 458fcea)
- 채널 퇴장 시, communityId를 Param으로 받지 않도록 수정함. (채널 삭제와 url 통일성, 대신 service에서 communityId를 알기 위해 DB에 접근이 필요함) (cherry picked from commit 4c3c5c9)
(cherry picked from commit f852613)
- findOne이 mongoose object를 반환하여 javascript object로 변환 (cherry picked from commit c88ca0d)
(cherry picked from commit 76da092)
(cherry picked from commit d5f0298)
- 기존에는 _id만 받을 수 있었음 (cherry picked from commit 1cba216)
(cherry picked from commit 2dee4da)
(cherry picked from commit 15e50b7)
* fix: docker secrete 설정 * github test pr * final fix (cherry picked from commit 5aecc90)
(cherry picked from commit a7acfe5)
(cherry picked from commit 14c6fb7)
(cherry picked from commit a8d5324)
(cherry picked from commit e7d8404)
(cherry picked from commit 114f891)
(cherry picked from commit c523064)
(cherry picked from commit 5bb64ad)
(cherry picked from commit ef7026b)
(cherry picked from commit c6d124c)
(cherry picked from commit 0b7ae8c)
(cherry picked from commit 6482c1a)
(cherry picked from commit 53470e4)
(cherry picked from commit 9789543)
(cherry picked from commit b9ebca5)
(cherry picked from commit 9166200)
- Param으로 받아올 값에 오타 수정 (cherry picked from commit 63510cb)
(cherry picked from commit 0d30ea8)
(cherry picked from commit eb6ee3b)
(cherry picked from commit 457aefc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
🤷♂️ Description