Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Server/Feature] get communities 중간 merge #120

Merged
merged 7 commits into from
Nov 24, 2022
Merged

[Server/Feature] get communities 중간 merge #120

merged 7 commits into from
Nov 24, 2022

Conversation

NaayoungKwon
Copy link
Collaborator

@NaayoungKwon NaayoungKwon commented Nov 24, 2022 •
edited
Loading

Issues

🤷‍♂️ Description

  • 사용자 스키마 내부의 커뮤니티 스키마 변경
communities : {
  _id : {
      _id : _id, (community _id)
      channels : {
           _id : {  _id (channel _id), lastRead: Date }
       }
  }
}
  • throw error 일원화

@NaayoungKwon NaayoungKwon added the 🌐 server 서버 작업 label Nov 24, 2022
@NaayoungKwon NaayoungKwon added this to the ⛰️ Week3 milestone Nov 24, 2022
@github-actions
Copy link

Tests Skipped Failures Errors Time
13 0 💤 1 ❌ 0 🔥 1m 3s ⏱️

soomanbaek
soomanbaek reviewed Nov 24, 2022
View reviewed changes
server/apps/api/src/community/community.service.ts
Comment on lines +77 to +79
_id: deleteCommunityDto.community_id,
managerId: deleteCommunityDto.managerId,
deletedAt: { $exists: false },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이 방법 엄청 좋네요! 👍

soomanbaek
soomanbaek approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@soomanbaek soomanbaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 천재시네요!! 😇 수고하셨어요~

@soomanbaek soomanbaek merged commit 8d88b24 into dev-be Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soomanbaek soomanbaek soomanbaek approved these changes

Assignees
No one assigned
Labels
🌐 server 서버 작업
Projects
None yet
Milestone
⛰️ Week3
Development

Successfully merging this pull request may close these issues.
2 participants
@NaayoungKwon @soomanbaek