Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server/Feat, Refactor] 커뮤니티에 사용자 추가 및 user controller refactor #106

Merged
merged 8 commits into from
Nov 23, 2022

Conversation

NaayoungKwon
Copy link
Collaborator

Issues

[Feature]

[Refactor]

🤷‍♂️ Description

  • 커뮤니티에 사용자 배열을 입력받아 추가
  • auth token을 사용해 현재 request user _id 확인하여 전달

📷 Screenshots

  • 정상 동작
    image

  • 커뮤니티 _id error
    image

  • 추가 요청 사용자 _id error

image

@NaayoungKwon NaayoungKwon added the 🌐 server 서버 작업 label Nov 22, 2022
@NaayoungKwon NaayoungKwon added this to the ⛰️ Week3 milestone Nov 22, 2022
@github-actions
Copy link

github-actions bot commented Nov 22, 2022

Tests Skipped Failures Errors Time
13 0 💤 0 ❌ 0 🔥 1m 16s ⏱️
Coverage Report (40%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files41.2139.5827.6540.08 
apps0000 
   webhook.interceptor.ts00001–32
apps/api/src100100100100 
   api.service.ts100100100100 
apps/api/src/auth0000 
   auth.service.ts00001–49
apps/api/src/auth/dto01001000 
   index.ts010010001–2
apps/api/src/auth/guard01001000 
   index.ts010010001–2
   jwt-access.guard.ts010010001–5
   jwt-refresh.guard.ts010010001–5
apps/api/src/auth/helper010000 
   signToken.ts0100001–28
apps/api/src/auth/strategy0000 
   index.ts010010001–2
   jwt-access.strategy.ts00001–22
   jwt-refresh.strategy.ts00001–39
apps/api/src/channel01001000 
   channel.service.ts010010001–4
apps/api/src/community4504038.88 
   community.service.ts4504038.8822–51
apps/api/src/user92.6886.3610091.89 
   user.service.ts92.6886.3610091.8915, 65, 82
apps/api/test010000 
   app.e2e-spec.ts0100001–19
apps/socket/src100100100100 
   socket.service.ts100100100100 
apps/socket/test010000 
   app.e2e-spec.ts0100001–19
dao/repository48.4810015.3841.37 
   community.repository.ts57.14100255012–23
   user.repository.ts42.110011.1135.2912–43
dao/schemas100100100100 
   community.schema.ts100100100100 
   user.schema.ts100100100100 
utils100100100100 
   def.ts100100100100 

Copy link
Member

@soomanbaek soomanbaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어제 약속이 있었음에도 끝나고 계속 개발하는 모습 리스펙트 합니다! 👍👍

이따 오피스 오시면 궁금한거 여쭤보고 머지할께요~

@@ -4,7 +4,7 @@ import { IsNotEmpty, IsString } from 'class-validator';

export type CommunityDocument = Community & Document;

@Schema()
@Schema({ timestamps: true })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우와 엄청 좋네요

@soomanbaek soomanbaek merged commit d6829fe into dev-be Nov 23, 2022
@NaayoungKwon NaayoungKwon deleted the refactor/auth-token branch November 25, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 server 서버 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants