Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: 업데이트 실패 유저 조회 시 예외 처리 #299

Merged
merged 3 commits into from
Dec 13, 2022
Merged

Feature: 업데이트 실패 유저 조회 시 예외 처리 #299

merged 3 commits into from
Dec 13, 2022

Conversation

wkddntjr1123
Copy link
Member

👀 What is this PR?

  • 업데이트 실패 유저 시 204 반환
  • 업데이트 실패 유저는 조회수 상승 X
  • 업데이트 실패 유저 수동 새로고침 시 딜레이 추가

📌 Related issue(s)

📝 Changes

📷 Attachment

@wkddntjr1123 wkddntjr1123 requested a review from a team as a code owner December 13, 2022 03:22
@wkddntjr1123 wkddntjr1123 requested review from Yaminyam, asdf99245 and tunggary and removed request for a team December 13, 2022 03:22
@github-actions github-actions bot added the ⚙️ backend backend label Dec 13, 2022
@wkddntjr1123 wkddntjr1123 added the ✨ feature New feature label Dec 13, 2022
asdf99245
asdf99245 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@asdf99245 asdf99245 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

업데이트 성공은 불가능한가요?

@wkddntjr1123
Copy link
Member Author

업데이트 성공은 불가능한가요?

github API 요청을 줄이는 것과 쿼리를 짧게 하는 거, 두 개가 trade off라 일단은 어쩔 수가 없는 부분같네요. 너무 특이한 케이스라 해결법을 찾아봐야겠어요

@asdf99245 asdf99245 merged commit 669d373 into develop Dec 13, 2022
@asdf99245 asdf99245 deleted the feature/error-user-profile branch December 13, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tunggary tunggary tunggary approved these changes

@asdf99245 asdf99245 asdf99245 approved these changes

@Yaminyam Yaminyam Awaiting requested review from Yaminyam Yaminyam is a code owner automatically assigned from boostcampwm-2022/team

Assignees

@wkddntjr1123 wkddntjr1123

Labels
⚙️ backend backend ✨ feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkddntjr1123 @asdf99245 @tunggary