Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: score history 라인차트 수정 #298

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Conversation

asdf99245
Copy link
Member

👀 What is this PR?

  • score history 라인차트 수정

📌 Related issue(s)

📝 Changes

  • 라인차트 선 아래 영역의 base line 설정
  • 스코어 히스토리 데이터 시간을 한국시간(KST)로 고정
  • 라인차트 axis 스타일 수정

📷 Attachment

image

@asdf99245 asdf99245 added ✨ feature New feature 🎨 frontend frontend labels Dec 13, 2022
@asdf99245 asdf99245 self-assigned this Dec 13, 2022
@asdf99245 asdf99245 requested a review from a team as a code owner December 13, 2022 03:17
@asdf99245 asdf99245 requested review from Yaminyam, wkddntjr1123 and tunggary and removed request for a team December 13, 2022 03:17
@asdf99245 asdf99245 changed the title Fix: score history 라인차트 수정 Feature: score history 라인차트 수정 Dec 13, 2022
export const getKSTDateString = (date: Date) => {
const utc = date.getTime() + date.getTimezoneOffset() * 60 * 1000;
const KR_TIME_DIFF = 9 * 60 * 60 * 1000;
const kst_date = new Date(utc + KR_TIME_DIFF);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한국 표준시간으로 바꾸셨군요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asdf99245 asdf99245 merged commit 07940be into develop Dec 13, 2022
@asdf99245 asdf99245 deleted the fix/score-history branch December 13, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 frontend frontend ✨ feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants