Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.0 개선사항 수정 #319

Merged
merged 8 commits into from
Dec 14, 2022
Merged

v0.5.0 개선사항 수정 #319

merged 8 commits into from
Dec 14, 2022

Conversation

parkhyeonki
Copy link
Member

개요

개선 사항 수정

변경 사항

  • 뷰어 레이아웃 버튼들 위로 ✔
  • 수정 모달 스크랩 변경하는 부분 UI ✔
  • TOC 프로필 ✔
  • 유저 object fit ✔
  • TOC 이모지 ✔
  • TOC z-index ✔
  • 뷰어 이미지 최대 넓이 ✔
  • 글에 들어가서 뷰어 페이지 삭제하면 스크랩 순서가 오더값 정렬 로직이 빠져있음 ✔

참고 사항

  • 민형님과 함께 개선사항 수정했습니다.
  • 회의실에서 함께 보시죠

@github-actions
Copy link

⚡️ Lighthouse report!

Category Score
🟢 Performance 92
🟢 Accessibility 97
🟢 Best Practices 92
🟢 SEO 100

@parkhyeonki parkhyeonki changed the title 개선사항 수정 v0.5.0 개선사항 수정 Dec 14, 2022
Copy link
Collaborator

@dahyeon405 dahyeon405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@parkhyeonki parkhyeonki merged commit 3b794e9 into develop Dec 14, 2022
@parkhyeonki parkhyeonki deleted the refactor/UI branch December 14, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FE Frontend IMPROVE Improve Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants