프로필 화면에서 팔로우 버튼 활성화, 기타 관련 기능 구현 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user데이터를 fetch 하는 useEffect에 유저 변경 의존성 추가
조회 시 모든 field를 가져오도록 수정
뒤로가기 버튼이 home으로 이동에서 바로 이전으로 이동
NEM-NE
reviewed
Nov 18, 2021
| setLoading(false); | ||
| }); | ||
| }, []); | ||
| console.log(props.userData); |
|
|
||
| return ( | ||
| <UserCardLayout sizeType={props.cardType}> | ||
| <UserCardLayout onClick={() => props.cardType !== 'others' && history.push(`/profile/${props.userData.userId}`)} sizeType={props.cardType}> |
There was a problem hiding this comment.
오늘 Link로 하면 스타일 이슈가 생길 수도 있다고 하셨는데 그래서 history를 사용한건가요?
There was a problem hiding this comment.
props.cardType이 others인 경우에는 링크가 걸리면 안되서 히스토리 사용했습니다!
Comment on lines
+16
to
+23
| fetch(`${process.env.REACT_APP_API_URL}/api/user/follow`, { | ||
| method: 'POST', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| }, | ||
| credentials: 'include', | ||
| body: JSON.stringify({ type, targetUserDocumentId }), | ||
| }).then((res) => res.json()) |
Comment on lines
+16
to
+23
| description: string, | ||
| profileUrl: string, | ||
| isFollow?: boolean, | ||
| } | ||
|
|
||
| function FollowerView({ match }: RouteComponentProps<{id: string}>) { | ||
| const userId = match.params.id; | ||
| const [nowItemList, nowItemType] = useFetchItems<any>(`/user/followers/${userId}`, 'followers'); | ||
| const [nowItemList, nowItemType] = useFetchItems<Required<IUserForCard>>(`/user/followers/${userId}`, 'followers'); |
Comment on lines
+11
to
+18
| interface IUserForCard{ | ||
| _id: string, | ||
| userName: string, | ||
| userId: string, | ||
| description: string, | ||
| profileUrl: string, | ||
| isFollow?: boolean, | ||
| } |
There was a problem hiding this comment.
follower-view에도 있는 인터페이스네요 저도 종종 자주 쓰이는 인터페이스가 있는데 저런 공통부분을 폴더를 만들어서 관리할까요?
There was a problem hiding this comment.
여러곳에서 쓰이는 interface는 폴더를 만들면 좋겠다는 생각이 듭니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
작업사항
변경 후