add explanation of compiler failure

boolafish · Oct 2, 2019 · 1b78d6e · 1b78d6e
1 parent dd38cba
commit 1b78d6e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/plasma_framework/contracts/src/exits/utils/BondSize.sol b/plasma_framework/contracts/src/exits/utils/BondSize.sol
@@ -31,6 +31,10 @@ library BondSize {
         pure
         returns (Params memory)
     {
+        // These requires would make compile to fail without optimizer on
+        // This contract itself would be fine, the problem seems to be the caller of this function cannot be inside constructor
+        // See this commit that solves the compiler issue:
+        // https://github.com/omisego/plasma-contracts/commit/b1161ef823076d978b925cd4f23776915bfcc020
         require(initialBondSize > 0, "initialBondSize cannot be 0");
         require(lowerBoundDivisor > 0, "lowerBoundDivisor cannot be 0");
         require(upperBoundMultiplier > 0, "upperBoundMultiplier cannot be 0");

diff --git a/plasma_framework/truffle-config.js b/plasma_framework/truffle-config.js
@@ -63,7 +63,7 @@ module.exports = {
             version: '0.5.12',
             settings: {
                 optimizer: {
-                    enabled: true,
+                    enabled: false,
                     runs: 200,
                 },
             },