-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Finna API connector #3498
Open
ilkka-ollakka
wants to merge
3
commits into
bookwyrm-social:main
Choose a base branch
from
ilkka-ollakka:feat/finna_connector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add Finna API connector #3498
ilkka-ollakka
wants to merge
3
commits into
bookwyrm-social:main
from
ilkka-ollakka:feat/finna_connector
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc4a0a2
to
9f1b59f
Compare
osma
reviewed
Jan 30, 2025
osma
reviewed
Jan 30, 2025
430e56e
to
980dd4c
Compare
Fixed editions loading and picking edition from work so it prefers books over audiobook/ebook and finnish/swedish language ones if any found. |
980dd4c
to
c52c38f
Compare
c52c38f
to
1b4c4fe
Compare
Fixed the issues that pylint/mypy/black complained, seems that I needed to add finna_key, so added it as separated first commit. |
1b4c4fe
to
3cdf225
Compare
Cleaned out locale changes that jumped in by accident in some rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finna connector
Finna is finnish open API that contains among other things books released in finland
terms of use this API is located in https://www.kiwi.fi/display/Finna/Finna+API+Terms+of+Use and is CC0
more info https://www.finna.fi/Content/about_finnafi
Connector is heavily borrowed from openlibrary and inventaire codebase, this is my first PR toward bookwyrm codebase, so there might be somethings that I have fully missed.
Original thread where the idea started and people pitched ideas and approaches https://mementomori.social/@anotherdream/113881912359314786
What type of Pull Request is this?
Does this PR change settings or dependencies, or break something?
Details of breaking or configuration changes (if any of above checked)
Enables Finna connector
Documentation
Tests