Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Finna API connector #3498

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ilkka-ollakka
Copy link

@ilkka-ollakka ilkka-ollakka commented Jan 29, 2025

Description

Finna connector

Finna is finnish open API that contains among other things books released in finland

terms of use this API is located in https://www.kiwi.fi/display/Finna/Finna+API+Terms+of+Use and is CC0

more info https://www.finna.fi/Content/about_finnafi

Connector is heavily borrowed from openlibrary and inventaire codebase, this is my first PR toward bookwyrm codebase, so there might be somethings that I have fully missed.

kuva
kuva

Original thread where the idea started and people pitched ideas and approaches https://mementomori.social/@anotherdream/113881912359314786

What type of Pull Request is this?

  • Bug Fix
  • Enhancement
  • Plumbing / Internals / Dependencies
  • Refactor

Does this PR change settings or dependencies, or break something?

  • This PR changes or adds default settings, configuration, or .env values
  • This PR changes or adds dependencies
  • This PR introduces other breaking changes

Details of breaking or configuration changes (if any of above checked)

Enables Finna connector

Documentation

  • New or amended documentation will be required if this PR is merged
  • I have created a matching pull request in the Documentation repository
  • I intend to create a matching pull request in the Documentation repository after this PR is merged

Tests

  • My changes do not need new tests
  • All tests I have added are passing
  • I have written tests but need help to make them pass
  • I have not written tests and need help to write them

@ilkka-ollakka ilkka-ollakka force-pushed the feat/finna_connector branch 4 times, most recently from bc4a0a2 to 9f1b59f Compare January 29, 2025 20:38
@ilkka-ollakka ilkka-ollakka marked this pull request as ready for review January 29, 2025 20:38
@ilkka-ollakka ilkka-ollakka changed the title Feat/finna connector add Finna API connector Jan 29, 2025
bookwyrm/connectors/finna.py Outdated Show resolved Hide resolved
bookwyrm/connectors/finna.py Outdated Show resolved Hide resolved
@ilkka-ollakka ilkka-ollakka force-pushed the feat/finna_connector branch 5 times, most recently from 430e56e to 980dd4c Compare February 1, 2025 18:16
@ilkka-ollakka
Copy link
Author

Fixed editions loading and picking edition from work so it prefers books over audiobook/ebook and finnish/swedish language ones if any found.

@ilkka-ollakka
Copy link
Author

Fixed the issues that pylint/mypy/black complained, seems that I needed to add finna_key, so added it as separated first commit.

@ilkka-ollakka
Copy link
Author

Cleaned out locale changes that jumped in by accident in some rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a connector to the Finna API
2 participants