Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alters get_description code for inventaire queries #3492

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Alters get_description code for inventaire queries #3492

merged 2 commits into from
Jan 11, 2025

Conversation

mouse-reeve
Copy link
Member

@mouse-reeve mouse-reeve commented Jan 11, 2025 •
edited
Loading

Description

We are malforming requests to inventaire by sending json blobs as strings. This fixed that.

What type of Pull Request is this?

  • Bug Fix
  • Enhancement
  • Plumbing / Internals / Dependencies
  • Refactor

Does this PR change settings or dependencies, or break something?

  • This PR changes or adds default settings, configuration, or .env values
  • This PR changes or adds dependencies
  • This PR introduces other breaking changes

Details of breaking or configuration changes (if any of above checked)

Documentation

  • New or amended documentation will be required if this PR is merged
  • I have created a matching pull request in the Documentation repository
  • I intend to create a matching pull request in the Documentation repository after this PR is merged

Tests

  • My changes do not need new tests
  • All tests I have added are passing
  • I have written tests but need help to make them pass
  • I have not written tests and need help to write them

@mouse-reeve mouse-reeve merged commit 03bab92 into main Jan 11, 2025
10 checks passed
@mouse-reeve mouse-reeve deleted the inventaire-titles branch January 11, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erroneous get_description requests to Inventaire
1 participant
@mouse-reeve