Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/Hide password icon #3029

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

skmanohar
Copy link
Contributor

Addresses #2884

Adds two new icons, eye and eye-blocked from icomoon free pack - https://icomoon.io/#preview-free

@jaschaurbach
Copy link
Member

It would be great if you would address the failed checks. Thanks!

@skmanohar
Copy link
Contributor Author

skmanohar commented Oct 14, 2023

My bad!
Sorting out an error I'm getting during stylelint. Don't re-run the workflows yet.

@mouse-reeve
Copy link
Member

Oh sorry I reflexively clicked the workflows before I saw that you just said you weren't ready yet 😅

@skmanohar skmanohar marked this pull request as draft October 14, 2023 15:03
@skmanohar
Copy link
Contributor Author

skmanohar commented Oct 14, 2023

Marking this as draft till I figure out what's going on. I'm running into #3032 and #3031. Could very well turn out to be my local issue. Meanwhile, if anyone would like to address #2884 , they could use the changes in this PR if it helps.

@jaschaurbach
Copy link
Member

I updated main to remove one eslint warning which was introduced by me and I just forgot to fix it.

@skmanohar skmanohar marked this pull request as ready for review October 18, 2023 16:05
@skmanohar
Copy link
Contributor Author

Thanks for the quick fix with .prettierrc !
I ran prettier after the config change and this PR should hopefully pass the checks now.

@jaschaurbach jaschaurbach merged commit abebf82 into bookwyrm-social:main Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants