Convert description from Markdown when importing from Open Library #2935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mouse-reeve
requested changes
Aug 2, 2023
|
clean is already called when the data is converted to HtmlField (which actually caused the original issue), but I agree it would be good to call it here as well to sanitize the data closer to input.
|
mouse-reeve
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description from Open Library is in Markdown format. When importing from Open Library the description gets sanitised as if it is HTML. This breaks Markdown blockquote as the
>gets converted to>. Other Markdown syntax seems to work as the description field seems to be able to handle both Markdown and HTML. Is it the intention to support a mix of Markdown and HTML in the database?Fixes #2930