-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isbn hyphenation #2921
Isbn hyphenation #2921
Conversation
…o copy button This partially reverts commit d2c4785.
As detailed on wikipedia and in this manual, the ISBN-13 has 5 parts: GS1 prefix, registration group, registrant, publication, and checksum. The GS1 prefix is always 3 digits, and the checksum is always 1 digit. The other parts are variable length, and the range message helps determine their length for a given ISBN-13. |
Tests:
|
In my naivety I would have thought you could solve this with a simple regex! Thank you for such a thorough PR. I think it may make the most sense to update the ranegfile from a management command? But that's a question for another day. |
For #2892
Here is information about the range message: https://www.isbn-international.org/range_file_generation. That page also has a link to download the range message, and provides the URL where you can send a request for the range message. I happened to notice that the range message had 1 very minor update over a period of about 3 days. This could help inform a decision about how often, or if, we need to update the range message in production. In this PR I included a function that can be used to update the range message, but it isn't called anywhere.