Don't show the series as a link if the book has no author #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The series link needs an author so if it doesn't have one, instead of showing a server error let's just show the series details as plain text without a link. Fixes: bookwyrm-social#2797
WesleyAC
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
It's a little unfortunate to have separate if statements for the opening and closing tag, but I can't figure out a way to do it that would be much better than this — the thing that comes to mind is making a variable for the title of the book with the series number, but Django's with tag is seriously annoying to use, and concatenation of strings with it is tricky, so this seems fine as is.
Thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The series link needs an author so if it doesn't have one, instead of showing a server error let's just show the series details as plain text without a link.
Fixes: #2797