Optimize get_audience #2785
Merged
Optimize get_audience #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect this will make some future work simpler.
This avoids filtering for the user that made the post in the same query as we use for other things, which should allow for better use of indices in all cases. Previously, bookwyrm-social#2723 did some work on this that only worked for some cases in HomeStream, but this code should work for all cases. Related: bookwyrm-social#2720
55f02d8 to
07b50a1
Compare
|
@mouse-reeve conflict resolved :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2720 (as well as the commit messages) for details. I haven't done detailed performance analysis on these queries (in part because doing so well would require data from #2779 in prod), but I think it's highly likely that these changes will allow Postgres to use the indices it has, and reduce these queries from ~8 seconds to hundreds of milliseconds at most, given that's what I saw for the narrower case of this that I analyzed before.
I don't have a super high level of confidence in this code, but it is to the best of my knowledge correct. This is just a fiddly part of the codebase, so I want to be careful.