-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calibre import. Fixes #627 #2093
Conversation
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
What is needed to push this PR forward? |
I just need some time -- I'm dealing with some outside life stuff right now that has temporarily tanked my ability to do more than respond to questions at the moment. But I'm excited to review this when I have a brain that can read code back in my head :) |
Alright. Take your time. I'm looking into picking up another issue in the meantime. |
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
I'm hitting an error when I run this -- It looks like what's happening is that when the importer tries to create a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(The requested changes are the comment above, I'm just updating the state so it's easier for me to keep track of PRs)
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
I believe I've addressed the issue. However, I couldn't run black here due to https://stackoverflow.com/questions/71673404/importerror-cannot-import-name-unicodefun-from-click |
Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Looks great! Thanks so much for the fixes |
No description provided.