Notifications refactor #2082
Merged
Notifications refactor #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know why it felt important to do this but it did. The migrations are in one file now and don't need a merge migration.
In the new paradigm, a notification related to a status has users added to it and removed from it, rather than a new notification being added every time. These helper functions make this behavior consistent.
Right now notifications are a mix of post-save signals and clauses in the save function of the model. I'm not actually sure which is better, but I'm moving them to signals where it's straightforward to be consistent.
Since the main way to interact with them is by approving them in the notification, I didn't group them
hughrun
reviewed
Jul 6, 2022
Thank you! I'm not seeing any comments besides this one |
hughrun
requested changes
Jul 6, 2022
This test will catch my typo in generating the notifications
mouse-reeve
commented
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor will allow similar notifications to be grouped. For example, instead of having 10 unique notifications that 10 different users liked a status, you can have one notification that lists all 10 users.
Example:
Remaining work:
Works on #2066