Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow book subjects to be edited #2000

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Conversation

Tak
Copy link
Contributor

@Tak Tak commented Mar 9, 2022

Just adds another comma-separated field below Languages

@mouse-reeve
Copy link
Member

This is a great change, thank you! Before I merge it, I'm trying to understand the field a bit better to supply some guidance to users about how to use this field. They're sourced from OpenLibrary which doesn't have any info, and doesn't seem to expose them at all in their interface to view or edit books. I thought they might be BISAC subjects, but that doesn't appear to be the case. For example, the "subjects" field in: https://openlibrary.org/books/OL15615497M.json

I think, with a little more info on what kinds of things to suggest, this is a good place for free text fields with an autocomplete trie (which is currently only used when supplying the file link type from the books view).

@Tak
Copy link
Contributor Author

Tak commented Mar 12, 2022

I think they're just freeform tags: see internetarchive/openlibrary#6074

@mouse-reeve
Copy link
Member

The subjects that are presented in the json view are similar but different than the freeform subjects in the UI -- but it may be that they're just being formatted different or reprocessed? For example, on https://openlibrary.org/books/OL3708706M/Carry_on_Jeeves:

"subjects": [
"Wooster, Bertie (Fictitious character) -- Fiction.",
"Jeeves (Fictitious character) -- Fiction.",
"Single men -- Fiction.",
"Valets -- Fiction.",
"England -- Fiction."
],

vs

Bertie Wooster (Fictitious character), Classic Literature, Valets, Butlers, Fiction, Single men, Humorous stories, English, English Humorous stories, Jeeves (Fictitious character), Jeeves (fictitious character), fiction, Wooster, bertie (fictitious character), fiction, Fiction, humorous, England, fiction, Fiction, humorous, general, British and irish fiction (fictional works by one author)

But I haven't dug into OpenLibrary's github on this, where I'm sure there's an answer. At any rate, it sounds like there isn't some objective standard for this (which makes sense). I think it would be handy to have suggestions to help keep consistency across subject tags, but the trie will need to be generated on the fly, which is a separate coding task outside the scope of this PR

@mouse-reeve
Copy link
Member

For all my dithering, this is a good change! I'll merge and try to figure out more about how to guide people on metadata in future PRs :)

@mouse-reeve mouse-reeve merged commit 6ddf1aa into bookwyrm-social:main Mar 14, 2022
@Tak Tak deleted the edit-subjects branch March 14, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants