Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "Post" to "Save" on edit page #2642

Closed
WesleyAC opened this issue Feb 1, 2023 · 0 comments · Fixed by #2922
Closed

Change "Post" to "Save" on edit page #2642

WesleyAC opened this issue Feb 1, 2023 · 0 comments · Fixed by #2922
Labels
good first issue Good for newcomers

Comments

@WesleyAC
Copy link
Member

WesleyAC commented Feb 1, 2023

On the page to edit a quote (and possibly a review/status/etc as well, I haven't checked), the button to save the edit says "Post" — this is confusing, since it implies (to me) that a new post is being made.

Instead, the button should say "Save" or something similar.
@hughrun hughrun added the good first issue Good for newcomers label Feb 8, 2023
@varanasib varanasib mentioned this issue Feb 16, 2023
Open
tararoshan added a commit to tararoshan/bookwyrm that referenced this issue Jul 27, 2023
@tararoshan
Indicate edited post is saved
9cd599d 
Should close bookwyrm-social#2642 and bookwyrm-social#2671. Gives a minimal solution to bookwyrm-social#2668.
@tararoshan tararoshan mentioned this issue Jul 27, 2023
Merged
hughrun added a commit that referenced this issue Jul 31, 2023
@hughrun
Merge pull request #2922 from tararoshan/wip-edit-post-and-save
c29ca5a 
fix button text when editing posts

Resolves #2642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix button text when editing posts tararoshan/bookwyrm
2 participants
@WesleyAC @hughrun