Merge pull request #2857 from bpeel/no-rating

Show “no rating” instead of blank stars if the review has no rating
bookwyrm-social · May 30, 2023 · d251f42 · d251f42
2 parents aec99ba + 603b2d9
commit d251f42
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 22 deletions.
diff --git a/bookwyrm/static/css/bookwyrm/components/_stars.scss b/bookwyrm/static/css/bookwyrm/components/_stars.scss
@@ -5,6 +5,10 @@
     white-space: nowrap;
 }
 
+.stars .no-rating {
+    font-style: italic;
+}
+
 /** Stars in a review form
  *
  * Specificity makes hovering taking over checked inputs.

diff --git a/bookwyrm/templates/book/book.html b/bookwyrm/templates/book/book.html
@@ -190,13 +190,15 @@ <h1 class="title" itemprop="name" dir="auto">
                     <meta itemprop="bestRating" content="5">
                     <meta itemprop="reviewCount" content="{{ review_count }}">
 
-                    {% include 'snippets/stars.html' with rating=rating %}
+                    <span>
+                        {% include 'snippets/stars.html' with rating=rating %}
 
-                    {% blocktrans count counter=review_count trimmed %}
-                        ({{ review_count }} review)
-                    {% plural %}
-                        ({{ review_count }} reviews)
-                    {% endblocktrans %}
+                        {% blocktrans count counter=review_count trimmed %}
+                            ({{ review_count }} review)
+                        {% plural %}
+                            ({{ review_count }} reviews)
+                        {% endblocktrans %}
+                    </span>
                 </div>
 
                 {% with full=book|book_description itemprop='abstract' %}

diff --git a/bookwyrm/templates/snippets/stars.html b/bookwyrm/templates/snippets/stars.html
@@ -2,26 +2,25 @@
 {% load i18n %}
 
 <span class="stars">
-    <span class="is-sr-only">
-        {% if rating %}
+    {% if rating %}
+        <span class="is-sr-only">
             {% blocktranslate trimmed with rating=rating|floatformat:0 count counter=rating|floatformat:0|add:0 %}
                 {{ rating }} star
             {% plural %}
                 {{ rating }} stars
             {% endblocktranslate %}
-        {% else %}
-            {% trans "No rating" %}
-        {% endif %}
-    </span>
-
-    {% for i in '12345'|make_list %}
-        <span
-            class="
-                icon is-small mr-1
-                icon-star-{% if rating >= forloop.counter %}full{% elif rating|floatformat:0 >= forloop.counter|floatformat:0 %}half{% else %}empty{% endif %}
-            "
-            aria-hidden="true"
-        ></span>
-    {% endfor %}
+        </span>
+        {% for i in '12345'|make_list %}
+            <span
+                class="
+                    icon is-small mr-1
+                    icon-star-{% if rating >= forloop.counter %}full{% elif rating|floatformat:0 >= forloop.counter|floatformat:0 %}half{% else %}empty{% endif %}
+                "
+                aria-hidden="true"
+            ></span>
+        {% endfor %}
+    {% else %}
+        <span class="no-rating">{% trans "No rating" %}</span>
+    {% endif %}
 </span>
 {% endspaceless %}