Fix JOIN in author_search_vector_trigger, add missing WHERE clause

bookwyrm-social · Nov 25, 2023 · be93903 · be93903
1 parent be64c37
commit be93903
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/bookwyrm/migrations/0191_migrate_search_vec_triggers_to_pgtriggers.py b/bookwyrm/migrations/0191_migrate_search_vec_triggers_to_pgtriggers.py
@@ -32,8 +32,8 @@ class Migration(migrations.Migration):
             trigger=pgtrigger.compiler.Trigger(
                 name="reset_search_vector_on_author_edit",
                 sql=pgtrigger.compiler.UpsertTriggerSql(
-                    func="WITH book AS (SELECT bookwyrm_book.id AS row_id FROM bookwyrm_author LEFT OUTER JOIN bookwyrm_book_authors ON bookwyrm_book_authors.id = new.id LEFT OUTER JOIN bookwyrm_book ON bookwyrm_book.id = bookwyrm_book_authors.book_id) UPDATE bookwyrm_book SET search_vector = '' FROM book WHERE id = book.row_id;RETURN NEW;",
-                    hash="9c0a472e2bf60e63d593cce49f47972c7b227a00",
+                    func="WITH book AS (SELECT bookwyrm_book.id AS row_id FROM bookwyrm_author LEFT OUTER JOIN bookwyrm_book_authors ON bookwyrm_book_authors.author_id = bookwyrm_author.id LEFT OUTER JOIN bookwyrm_book ON bookwyrm_book.id = bookwyrm_book_authors.book_id WHERE bookwyrm_author.id = new.id ) UPDATE bookwyrm_book SET search_vector = '' FROM book WHERE id = book.row_id;RETURN NEW;",
+                    hash="abc8ea76fa1bf02a0f56aaae390c1b970bef1278",
                     operation='UPDATE OF "name"',
                     pgid="pgtrigger_reset_search_vector_on_author_edit_a447c",
                     table="bookwyrm_author",

diff --git a/bookwyrm/models/author.py b/bookwyrm/models/author.py
@@ -81,9 +81,10 @@ class Meta:
                           SELECT bookwyrm_book.id AS row_id
                           FROM bookwyrm_author
                           LEFT OUTER JOIN bookwyrm_book_authors
-                            ON bookwyrm_book_authors.id = new.id
+                            ON bookwyrm_book_authors.author_id = bookwyrm_author.id
                           LEFT OUTER JOIN bookwyrm_book
                             ON bookwyrm_book.id = bookwyrm_book_authors.book_id
+                          WHERE bookwyrm_author.id = new.id
                     )
                     UPDATE bookwyrm_book
                     SET search_vector = ''