This repository has been archived by the owner on May 3, 2022. It is now read-only.
Improve our Makefile #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using variables like $SHIPPER_IMAGE instead of $(SHIPPER_IMAGE) causes errors like this: /bin/sh: HIPPER_IMAGE: command not found It appears make interpolates variables like $(THIS) instead of like $THIS.
First of all, "shipper" is not a phony target [1]: it actually generates a binary called "shipper". I suppose it was declared as phony so `make shipper` would always be executed, instead of bailing out with "make: `shipper' is up to date." If we declare our dependencies correctly, though, it'll always execute if the dependencies are changed, which is most likely what we actually want, so let's do that. [1] https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
It's very useful to be able to override names of images and commands executed by the Makefile during testing. I can have my own image registry, put shipper in any namespace I want, and I can also teach it to work with microk8s.kubectl without having to resort to symlinks :)
osdrv
previously approved these changes
May 14, 2019
Silly me, pkg/* doesn't actually go deeper than 1 level, pkg/**/* is needed for that. Without it, modifying any files inside any directory in pkg/ or vendor/ and then calling `make shipper` wouldn't actually result in the task being executed.
parhamdoustdar
approved these changes
May 17, 2019
osdrv
approved these changes
May 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that a Makefile was introduced, I tried to use it and it just didn't work at all for what I wanted to do. I made some changes that fixed the broken things, and made some non-broken things that weren't possible possible.