This repository was archived by the owner on May 3, 2022. It is now read-only.
Bugfixes in release controller strategy executor #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses multiple issues identified in strategy executor, among which: * Wrong recepients for patch updates: due to an error in the code some patches were applied to a wrong generation of release and target objects. * Target object spec checkers used to return an incomplete spec if only some of the clusters are misbehaving: there was a risk of de-scheduling the workload on healthy clusters. Signed-off-by: Oleg Sidorov <oleg.sidorov@booking.com>
4b197e1 to
58a116b
Compare
juliogreff
approved these changes
Feb 20, 2020
|
|
||
| switch action := a.(type) { | ||
|
|
||
| case kubetesting.CreateActionImpl: | ||
| extra := fmt.Sprintf("Name: %s\n", action.Name) |
There was a problem hiding this comment.
Thank you for this one. Debugging tests with multiple objects was driving me crazy too :D
| HasIncumbent bool | ||
| IsLastStep bool | ||
| HasTail bool | ||
| Initiator *shipper.Release |
There was a problem hiding this comment.
I get what the Initiator is after reading the code, but without being familiar with how things work I don't think that the name carries enough meaning. I'm sorry I don't have a better suggestion, so I'll still approve, and if a better name comes up we can have a PR just to rename this.
osdrv
pushed a commit
that referenced
this pull request
Feb 20, 2020
…tency Due to a change introduced in #285, shipper strarted re-activating historical releases due to the way targetStep is resolved. The aforementioned step changed the composition of the pipeline and caused historical releases to be re-scheduled. This caused some historical items to re-activate their capacity and target targets. This change mainly reverts the re-composition of the pipeline and ensures the historical releases never re-activate their predecessors. Signed-off-by: Oleg Sidorov <oleg.sidorov@booking.com>
hihilla
pushed a commit
that referenced
this pull request
Feb 20, 2020
…tency Due to a change introduced in #285, shipper strarted re-activating historical releases due to the way targetStep is resolved. The aforementioned step changed the composition of the pipeline and caused historical releases to be re-scheduled. This caused some historical items to re-activate their capacity and target targets. This change mainly reverts the re-composition of the pipeline and ensures the historical releases never re-activate their predecessors. Signed-off-by: Oleg Sidorov <oleg.sidorov@booking.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses multiple issues identified in strategy executor,
among which:
patches were applied to a wrong generation of release and target
objects.
only some of the clusters are misbehaving: there was a risk of
de-scheduling the workload on healthy clusters.
Signed-off-by: Oleg Sidorov oleg.sidorov@booking.com