Allow RuntimeManager to load scripts stored as assembly resource files #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
reviewed
Feb 14, 2024
There was a problem hiding this comment.
Looks great, I just made the two helper functions private to the class.
In this case I also feel it may be better to centralize all reading logic into a single function to make it easier to understand where all the logic for reading the python code is located.
Co-authored-by: glopesdev <glopesdev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for loading python scripts in assembly
Loading Python Scripts in Assembly
A nice feature for integrating Python packages into Bonsai is the ability to package python scripts in Bonsai/NuGet packages which can be loaded directly through the RuntimeManager. To do this, the RuntimeManager just needs to detect whether ScriptPaths point to embedded resources and then load the embedded script. With this new feature, it is now possible for the RuntimeManager to parse the path of a script to determine: