-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@clack/prompts): multiselect maxItems option #151
feat(@clack/prompts): multiselect maxItems option #151
Conversation
🦋 Changeset detectedLatest commit: 3c739f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@cpreston321 This is from main branch, I did not changed this (state) behavior. |
@Mist3rBru Screenshot 1 was from main branch and screenshoot 2 was from your branch. try it out in both: |
…clack into multiselect-max-items
@cpreston321 the screenshots are testing different cases, the main:line#62 is concatenating the result with |
@Mist3rBru I thought it more of a symptom more then a test case. Since the maxItems was moved to a single function. So I figured it was it was a side effect. I don't think it was intentional on your side. |
@cpreston321 it is fine 😄. I gonna change this patch result to match multiselect result |
LGTM @Mist3rBru thanks for the PR! 🚀 |
This PR this introduces maxItems option to
multiselect
prompt, using the same logic asselect
prompt. Now both use the same utility function limitOptions that handles this logic.Demo
2023-08-26.13-09-17.mp4